feat: add tests and refactor #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novaknole
approved these changes
Aug 22, 2024
novaknole
merged commit 045a403
into
feature/targets-and-standardized-proposal
7 checks passed
novaknole
added a commit
that referenced
this pull request
Nov 5, 2024
* proposal and plugins interfaces changes with backwards compatibility * add artifacts folder in gitignore * fix calldata to memory * add tests * add operation type for target * feat: add tests and refactor (#100) * feat: add test for checking the ExecuteFailed is properly emitted * feat: add new case in mock executor to simulate the tests * feat: refactor code to avoid duplications * ci: fix solhint warnings * ci: fix lint issues * remove previous target from targetset event * add get proposalid in the interface * rename function * from calldata to memory * improved target config and virtual functions * add params byte approach (#102) * add params byte approach * add simple executor (#103) * add simple executor * action as free level export * executor added with reentrancy guard * call initialization only * add comments * fallback to dao as a target if no target set (#104) * metadata contracts (#105) * metadata contracts * rename * diamond storage for metadata * remove revert * Update contracts/src/executors/IExecutor.sol Co-authored-by: Jør∂¡ <[email protected]> * review changes * unused import remove * remove unusued import * from memory to calldata in metadataextension * create proposal id not enforced (#106) * create proposal id not enforced * new changes * remove unusued function * add condition (#108) * add condition * rename * fix linter * fix: executor 63/64 rule tests for coverage * feat: add tests for powerful condition contract * ci: undo changes * ci: rmv not used import * fix: prettier * feat: add tests for conditions that checks block number and timestamp * ci: prettier * ci: lint fix * Feat/rule condition clean up (#109) * cd: rename powerfulCondtion to RuledCondition * add natspecs * remove redandant imports * extension alwaystruecondition * extension folder * rename, fix and add tests * add rules updated event * Feat: add missing tests (#111) * feat: add test for always true condition * feat: modify mock code to allow sending the compare list on the data * feat: add tests for rule condition * feat: simplify ruled condition tests * fix lint * add supportsinterface on executor * change const name --------- Co-authored-by: Claudia <[email protected]> Co-authored-by: Rekard0 <[email protected]> * remove always true condition * add hasSucceeded instead of (#112) * add hasSucceeded instead of * remove .only --------- Co-authored-by: Claudia Barcelo <[email protected]> Co-authored-by: Jør∂¡ <[email protected]> Co-authored-by: Rekard0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add some needed tests and refactor #99
Task ID: OS-NO-ref
Checklist:
CHANGELOG.mdfile in the root folder.