Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update commons contracts to use commons config #67

Merged
merged 32 commits into from
Mar 13, 2024
Merged

feat: update commons contracts to use commons config #67

merged 32 commits into from
Mar 13, 2024

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented Mar 12, 2024 •
edited
Loading

Description

Refactor to use the new commons config networks in the commons contracts

Task ID: OS-1109

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.

Rekard0 and others added 29 commits March 7, 2024 11:18
@Rekard0
ci:change to public rpc
4438a1c
@clauBv23
Merge branch 'develop' into chore/use-public-rpc
f8ede2c
@clauBv23
feat: add change to changelog and update the package version
bd1a707
@clauBv23
feat: define new rpc urls
df48f27
@clauBv23
feat: add needed index
06ae211
@clauBv23
ci: update changelog
5b9480e
@clauBv23
feat: update the hardhat config file to use the common networks
801249e
@clauBv23
feat: update the .env.examples
ff36ade
@clauBv23
ci: remove not needed imports
9112e22
@clauBv23
feat: update the hardhat config to initialize the configuration
aec336c
@clauBv23
feat: add initializer function to provide the rpc apiKey to the netwo…
e3f6993 
…rks configuration
@clauBv23
Merge branch 'chore/use-public-rpc' into OS-1109/update-commons-contr…
ccdf8b6 
…acts-to-use-commons-config
@clauBv23
ci: remove not needed console logs
18bbbb7
@clauBv23
Merge branch 'chore/use-public-rpc' into OS-1109/update-commons-contr…
b156f7f 
…acts-to-use-commons-config
@clauBv23
feat: move the init function to the network file, and complete the rp…
16ad779 
…c url with the api key
@clauBv23
ci: change the string char
e282a55
@clauBv23
ci: remove my api key from the env examples
f69a7ab
@clauBv23
feat: refactor the hardhat config file
459b3e2
@clauBv23
feat: add commons config to the dependencies
0a18c59
@clauBv23
ci: update the comments in the env example
264b48e
@clauBv23
Merge branch 'chore/use-public-rpc' into OS-1109/update-commons-contr…
03b53b8 
…acts-to-use-commons-config
@clauBv23
feat: remove the rpc url from the networks and add a function to set …
40f4b35 
…the value given the rpc and the api key
@clauBv23
feat: update the changelog and the README
ba66e83
@clauBv23
ci: update readme
e57b416
@clauBv23
ci: remove comment
797d1e0
@clauBv23
Merge branch 'chore/use-public-rpc' into OS-1109/update-commons-contr…
bcf5b3b 
…acts-to-use-commons-config
@clauBv23
feat: update the hardhat config file to use the new addRpcUrlToNetwor…
370e43c 
…k from commons-config package
@clauBv23
feat: add new commons config version to contracts
b2b900b
@clauBv23
Merge branch 'develop' into OS-1109/update-commons-contracts-to-use-c…
4fd653e 
…ommons-config
@github-actions github-actions bot added the sdk label Mar 12, 2024
heueristik
heueristik approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to use PR titles following https://www.conventionalcommits.org/en/v1.0.0/ as the PR will get squashed and become a commit on the develop branch

@clauBv23 clauBv23 changed the title Os 1109/update commons contracts to use commons config feat: update commons contracts to use commons config Mar 12, 2024
@clauBv23
Copy link
Contributor Author

clauBv23 commented Mar 12, 2024 •
edited
Loading

Make sure to use PR titles following https://www.conventionalcommits.org/en/v1.0.0/ as the PR will get squashed and become a commit on the develop branch

sure, changed it, ty

@clauBv23 clauBv23 merged commit 96b2eda into develop Mar 13, 2024
11 checks passed
@clauBv23 clauBv23 deleted the OS-1109/update-commons-contracts-to-use-commons-config branch March 13, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@jordaniza jordaniza jordaniza approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
contracts sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clauBv23 @heueristik @jordaniza @Rekard0