New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add osx and plugins artifacts #97

Merged

clauBv23 merged 18 commits into develop from feat/add-osx-and-plugins-artifacts

Aug 7, 2024

Contributor

clauBv23 commented Aug 5, 2024 •

edited

Loading

Description

Create a new package for publishing the oss and the plugins abis.

Task ID: OS-1445

Checklist:

I have selected the correct base branch.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
Any dependent changes have been merged and published in downstream modules.
I created tasks to update dependent repositories (OSx, Plugins)
I ran all tests with success and extended them if necessary.
I have updated the CHANGELOG.md file in the root folder.

clauBv23 added 4 commits

August 5, 2024 17:24


          feat: initialize project

7db5ac9


          feat: add abis

ef54362


          feat: add workflow


          fix: update the pkg json to make the module work

3ed0d36

clauBv23 added the artifacts-release label

clauBv23 requested review from Rekard0 and novaknole

August 5, 2024 15:55

clauBv23 added 7 commits

August 6, 2024 17:42


          feat: remove the artifacts from the gitignore

83308ca


          feat: add script to automate the abis generation

d09d724


          feat: update the script file's name

0fba1d0


          feat: remove old abis files

ea2b823


          feat: remove the artifact from the foundry config

66fa650


          feat: rename package and update version

091630c


          feat: add .env file to set the alchemy key

0bc4ae1

novaknole reviewed

View reviewed changes

artifacts/generateAbis.sh Show resolved Hide resolved

novaknole reviewed

View reviewed changes

artifacts/generateAbis.sh Outdated Show resolved Hide resolved

novaknole reviewed

View reviewed changes

artifacts/src/index.ts Outdated Show resolved Hide resolved

novaknole reviewed

View reviewed changes

artifacts/wagmi.foundry.config.ts Outdated Show resolved Hide resolved

novaknole reviewed

View reviewed changes

artifacts/wagmi.hardhat.config.ts Outdated Show resolved Hide resolved

novaknole reviewed

View reviewed changes

Contributor

novaknole left a comment

A couple of easy changes required.

clauBv23 added 3 commits

August 7, 2024 12:21


          feat: remove artifacts from prettier ignore

bd4a510


          feat: fix formatting

1ff63a4


          feat: update the generate abi script to revert if the .env file is no…

f1d2d4e

…t defined

clauBv23 requested a review from novaknole

August 7, 2024 10:25

clauBv23 added 2 commits

August 7, 2024 12:28


          fix: prettier

01d702c


          feat: change package name

4ed9b36

Rekard0 reviewed

View reviewed changes

artifacts/CHANGELOG.md Outdated Show resolved Hide resolved

clauBv23 added 2 commits

August 7, 2024 15:34


          feat: rename package

ecadbc7


          feat: update the changelog to add the versions

07bec06

Rekard0 previously approved these changes

View reviewed changes

Contributor

Rekard0 left a comment

LGTM, please don't forget to follow up with: https://aragonassociation.atlassian.net/browse/OS-1457

clauBv23 changed the base branch from main to develop

August 7, 2024 14:32

clauBv23 dismissed Rekard0’s stale review

August 7, 2024 14:32

The base branch was changed.

clauBv23 requested a review from Rekard0

August 7, 2024 14:32

novaknole approved these changes

View reviewed changes

Rekard0 approved these changes

View reviewed changes

clauBv23 merged commit f6d0364 into develop

3 checks passed

clauBv23 deleted the feat/add-osx-and-plugins-artifacts branch

August 7, 2024 21:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

artifacts-release