-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #290 - Support PHP 8.1 #291
Conversation
Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues. |
fc1e66a
to
68299c0
Compare
Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues. |
Hello @Sweetchuck can you fix the PR please ? :D |
No. I am not gonna do that. ArangoDB should reconsider the contribution workflow. I would happily contribute more. For example remove the |
Wait what ? They require to sign and re-send a PDF ? oO |
68299c0
to
27c918f
Compare
I just rebased this branch to the latest „devel” branch. |
The fail is totally irrelevant. \ArangoDBClient\AdminTest::testGetServerMetrics line 262. But after that: static::assertTrue(is_numeric($metric["sum"])); Docker image arangodb/arangodb-preview:3.9.0-nightly as defined in tests/travis/setup_arangodb.sh Why nightly? |
Related Issue: #294 |
Issue #290 - Support PHP 8.1