Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #290 - Support PHP 8.1 #291

Closed
wants to merge 1 commit into from

Conversation

Sweetchuck
Copy link

Issue #290 - Support PHP 8.1

@cla-bot
Copy link

cla-bot bot commented Jan 18, 2022

Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

@Sweetchuck Sweetchuck force-pushed the issue-290-3.x-php-0801 branch from fc1e66a to 68299c0 Compare January 18, 2022 22:07
@cla-bot
Copy link

cla-bot bot commented Jan 18, 2022

Fresh avocado detected! Welcome and thank you for your contribution @Sweetchuck. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

@Geolim4
Copy link

Geolim4 commented Mar 30, 2022

Hello @Sweetchuck can you fix the PR please ? :D

@Sweetchuck
Copy link
Author

@Geolim4

  1. Download a PDF
  2. print it on papper
  3. fill the form and sign it
  4. send it back with fax (or other way)

No. I am not gonna do that.

ArangoDB should reconsider the contribution workflow.

I would happily contribute more. For example remove the tests/.phpunit.result.cache from the repository.

@Geolim4
Copy link

Geolim4 commented Mar 30, 2022

@Geolim4

1. Download a PDF

2. print it on papper

3. fill the form and sign it

4. send it back with fax (or other way)

No. I am not gonna do that.

ArangoDB should reconsider the contribution workflow.

I would happily contribute more. For example remove the tests/.phpunit.result.cache from the repository.

Wait what ? They require to sign and re-send a PDF ? oO
Didn't noticed that, my bad.
This new "CLA" trend is completely counterproductive.

@Sweetchuck Sweetchuck force-pushed the issue-290-3.x-php-0801 branch from 68299c0 to 27c918f Compare March 30, 2022 19:58
@Sweetchuck
Copy link
Author

I just rebased this branch to the latest „devel” branch.

@Sweetchuck
Copy link
Author

Sweetchuck commented Mar 30, 2022

The fail is totally irrelevant.

\ArangoDBClient\AdminTest::testGetServerMetrics line 262.
expected: arangodb_server_statistics_server_uptime_total
most closer actual: arangodb_server_statistics_server_uptime


But after that:
static::assertEquals("counter", $metric["type"]);
actual: gauge


static::assertTrue(is_numeric($metric["sum"]));
Undefined index: sum
/.../triagens/arangodb-php-3.x/tests/AdminTest.php:276


Docker image arangodb/arangodb-preview:3.9.0-nightly as defined in tests/travis/setup_arangodb.sh

Why nightly?

@Sweetchuck
Copy link
Author

Related Issue: #294

@Sweetchuck Sweetchuck closed this Dec 31, 2022
@Sweetchuck Sweetchuck deleted the issue-290-3.x-php-0801 branch December 31, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants