Add styled-components-ssr example #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Our plan though is to publish some of the more
common middlewares as official addons in the addon folder. Can
you look into doing that?
…--
Eiríkur Heiðar Nilsson
+354 869 3179 / @eirikurn
On July 4, 2018 at 12:03 PM, Noam Almosnino ([email protected]) wrote:
Created a styled-components-ssr example for future reference.
It includes a styled-components middleware for Tux.
You can view, comment on, or merge this pull request online at:
#155
Commit Summary
* Add styled-components-ssr example
File Changes
* A examples/.DS_Store
( https://github.com/aranja/tux/pull/155/files#diff-0 ) (0)
* A examples/styled-components-ssr/.gitignore
( https://github.com/aranja/tux/pull/155/files#diff-1 ) (15)
* A examples/styled-components-ssr/.neutrinorc.js
( https://github.com/aranja/tux/pull/155/files#diff-2 ) (12)
* A examples/styled-components-ssr/package.json
( https://github.com/aranja/tux/pull/155/files#diff-3 ) (26)
* A examples/styled-components-ssr/src/app.js
( https://github.com/aranja/tux/pull/155/files#diff-4 ) (15)
* A examples/styled-components-ssr/src/components/Description.js
( https://github.com/aranja/tux/pull/155/files#diff-5 ) (11)
* A examples/styled-components-ssr/src/components/Header.js
( https://github.com/aranja/tux/pull/155/files#diff-6 ) (23)
* A examples/styled-components-ssr/src/components/Home.js
( https://github.com/aranja/tux/pull/155/files#diff-7 ) (38)
* A
examples/styled-components-ssr/src/components/TuxLogo/TuxLogo.js
( https://github.com/aranja/tux/pull/155/files#diff-8 ) (17)
* A
examples/styled-components-ssr/src/components/TuxLogo/index.js
( https://github.com/aranja/tux/pull/155/files#diff-9 ) (1)
* A examples/styled-components-ssr/src/components/TuxLogo/tux.svg
( https://github.com/aranja/tux/pull/155/files#diff-10 ) (5)
* A
examples/styled-components-ssr/src/middlewares/styled-components/index.js
( https://github.com/aranja/tux/pull/155/files#diff-11 ) (17)
* A
examples/styled-components-ssr/src/middlewares/styled-components/neutrino.js
( https://github.com/aranja/tux/pull/155/files#diff-12 ) (25)
* A examples/styled-components-ssr/src/server/index.js
( https://github.com/aranja/tux/pull/155/files#diff-13 ) (16)
Patch Links:
* https://github.com/aranja/tux/pull/155.patch
* https://github.com/aranja/tux/pull/155.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
( #155 ), or mute the thread
( https://github.com/notifications/unsubscribe-auth/AAHBltJcluD5CBsWoILEm3j5aCok7eMpks5uDK7_gaJpZM4VCd-w )
.
|
|
Thanks! Makes sense - I'll look into the addons next. |
…his middleware. Todo: Figure out the best way to test this middleware and best way to test styled components in general.
|
Just committed the addon. The example now uses it as well. |
eirikurn
requested changes
Jul 9, 2018
| }, | ||
| "peerDependencies": { | ||
| "react": ">16.0.0-beta", | ||
| "react-chain": "^0.5.0" |
There was a problem hiding this comment.
Need peer dependency for styled-components. Actually does not depend on react.
There was a problem hiding this comment.
It also has a dependency on @neutrinojs/compile-loader and peer dependency on neutrino.
| yarn.lock | ||
| yarn-error.log | ||
| yarn.lock | ||
| yarn.lock |
There was a problem hiding this comment.
Duplicate ignore entries.
.DS_Store should arguably be in your global gitignore.
|
Thanks! I'll be making the edits. Agree about the README.md, I'll work on it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a styled-components-ssr example for future reference.
It includes a styled-components middleware for Tux.