Merge pull request #326 from arbs-io:feature/20250226-SplitCommands

Feature/20250226-SplitCommands

package.json

@@ -34,7 +34,7 @@
     "esbuild-base": "esbuild ./src/extension.ts --bundle --outfile=out/extension.js --external:vscode --format=cjs --platform=node --target=es2020",
     "esbuild": "yarn esbuild-base --sourcemap",
     "esbuild-watch": "yarn esbuild-base -- --sourcemap --watch",
-    "test-compile": "tsc -p ./",
+    "compile": "tsc -p ./",
     "deploy": "vsce publish --yarn",
     "clean": "node ./utilities/scripts/clean.js"
   },

src/commands/ICommand.ts

@@ -0,0 +1,5 @@
+export interface ICommand {
+  readonly id: string
+
+  execute(...args: any[]): void | Promise<void>
+}

src/commands/commandManager.ts

@@ -1,10 +1,5 @@
 import { commands, Disposable } from 'vscode'
-
-export interface Command {
-  readonly id: string
-
-  execute(...args: any[]): void
-}
+import { ICommand } from '@app/commands'
 
 export class CommandManager {
   private readonly _commands = new Map<string, Disposable>()
@@ -16,7 +11,7 @@ export class CommandManager {
     this._commands.clear()
   }
 
-  public register<T extends Command>(command: T): Disposable {
+  public register<T extends ICommand>(command: T): Disposable {
     this._registerCommand(command.id, command.execute, command)
     return new Disposable(() => {
       this._commands.delete(command.id)

src/commands/configuration/showQuickpick.ts

@@ -1,16 +1,16 @@
 import { ExtensionContext } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { ConfigurationQuickPickProvider } from '@app/providers'
 
-export default class SettingsCommand implements Command {
+export default class SettingsCommand implements ICommand {
   public readonly id = 'vscode-openai.configuration.show.quickpick'
   private _configurationQuickPick: ConfigurationQuickPickProvider
   public constructor(context: ExtensionContext) {
     this._configurationQuickPick =
       ConfigurationQuickPickProvider.getInstance(context)
   }
 
-  public async execute(): Promise<void> {
-    await this._configurationQuickPick.execute()
+  public async execute() {
+    this._configurationQuickPick.execute()
   }
 }

src/commands/conversation/copyClipboardSummary.ts

@@ -1,10 +1,10 @@
 import { env } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { showMessageWithTimeout } from '@app/apis/vscode'
 import { IConversation } from '@app/interfaces'
 
 export default class ClipboardCopyConversationSummaryCommand
-  implements Command
+  implements ICommand
 {
   public readonly id = '_vscode-openai.conversation.clipboard-copy.summary'
 

src/commands/conversation/delete.ts

@@ -1,9 +1,9 @@
 import { window } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { IConversation } from '@app/interfaces'
 import { ConversationStorageService } from '@app/services'
 
-export default class DeleteConversationCommand implements Command {
+export default class DeleteConversationCommand implements ICommand {
   public readonly id = '_vscode-openai.conversation.delete'
 
   public execute(args: { data: IConversation }) {

src/commands/conversation/newPersona.ts

@@ -1,12 +1,12 @@
 import { ExtensionContext } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { quickPickCreateConversation } from '@app/utilities/quickPicks'
 
-export default class NewConversationPersonaCommand implements Command {
+export default class NewConversationPersonaCommand implements ICommand {
   public readonly id = 'vscode-openai.conversation.new.persona'
   public constructor(private _context: ExtensionContext) {}
 
-  public async execute(): Promise<void> {
-    await quickPickCreateConversation(this._context)
+  public async execute() {
+    quickPickCreateConversation(this._context)
   }
 }

src/commands/conversation/newStandard.ts

@@ -1,13 +1,13 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { IConversation } from '@app/interfaces'
 import { getSystemPersonas } from '@app/models'
 import { ConversationStorageService } from '@app/services'
 import { VSCODE_OPENAI_QP_PERSONA } from '@app/constants'
 
-export default class NewConversationStandardCommand implements Command {
+export default class NewConversationStandardCommand implements ICommand {
   public readonly id = 'vscode-openai.conversation.new.standard'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     const persona = getSystemPersonas().find(
       (a) => a.roleName === VSCODE_OPENAI_QP_PERSONA.GENERAL
     )!

src/commands/conversation/openJson.ts

@@ -1,8 +1,8 @@
 import { ViewColumn, window, workspace } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { IConversation } from '@app/interfaces'
 
-export default class ShowConversationJsonCommand implements Command {
+export default class ShowConversationJsonCommand implements ICommand {
   public readonly id = '_vscode-openai.conversation.show.json'
 
   public execute(args: { data: IConversation }) {

src/commands/conversation/openMarkdown.ts

@@ -1,8 +1,8 @@
 import { ViewColumn, window, workspace } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { IConversation } from '@app/interfaces'
 
-export default class ShowConversationMarkdownCommand implements Command {
+export default class ShowConversationMarkdownCommand implements ICommand {
   public readonly id = '_vscode-openai.conversation.show.markdown'
 
   public execute(args: { data: IConversation }) {

src/commands/conversation/openWebview.ts

@@ -1,8 +1,8 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { IConversation } from '@app/interfaces'
 import { ConversationStorageService } from '@app/services'
 
-export default class OpenConversationWebviewCommand implements Command {
+export default class OpenConversationWebviewCommand implements ICommand {
   public readonly id = '_vscode-openai.conversation.open.webview'
 
   public execute(args: { data: IConversation }) {

src/commands/conversations/deleteAll.ts

@@ -1,11 +1,11 @@
 import { window } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { ConversationStorageService } from '@app/services'
 
-export default class DeleteAllConversationsCommand implements Command {
+export default class DeleteAllConversationsCommand implements ICommand {
   public readonly id = '_vscode-openai.conversations.delete-all'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     window
       .showInformationMessage(
         'Are you sure you want to delete ALL conversation?',

src/commands/conversations/refresh.ts

@@ -1,10 +1,10 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { ConversationStorageService } from '@app/services'
 
-export default class RefreshConversationsCommand implements Command {
+export default class RefreshConversationsCommand implements ICommand {
   public readonly id = '_vscode-openai.conversations.refresh'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     ConversationStorageService.instance.refresh()
   }
 }

src/commands/conversations/settings.ts

@@ -1,10 +1,10 @@
 import { commands } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 
-export default class SettingsConversationsCommand implements Command {
+export default class SettingsConversationsCommand implements ICommand {
   public readonly id = '_vscode-openai.conversations.settings'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     commands.executeCommand(
       'workbench.action.openSettings',
       'vscode-openai.conversation-configuration'

src/commands/editor/codeBounty.ts

@@ -1,15 +1,15 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { getSystemPersonas } from '@app/models'
 import {
   compareResultsToClipboard,
   getEditorPrompt,
 } from '@app/utilities/editor'
 import { VSCODE_OPENAI_QP_PERSONA } from '@app/constants'
 
-export default class CodeBountyCommand implements Command {
+export default class CodeBountyCommand implements ICommand {
   public readonly id = '_vscode-openai.editor.code.bounty'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     const prompt = await getEditorPrompt('editor.code.bounty')
     const persona = getSystemPersonas().find(
       (a) => a.roleName === VSCODE_OPENAI_QP_PERSONA.DEVELOPER

src/commands/editor/codeComment.ts

@@ -1,19 +1,19 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { getSystemPersonas } from '@app/models'
 import {
   compareResultsToClipboard,
   getEditorPrompt,
 } from '@app/utilities/editor'
 import { VSCODE_OPENAI_QP_PERSONA } from '@app/constants'
 
-export default class CodeCommentCommand implements Command {
+export default class CodeCommentCommand implements ICommand {
   public readonly id = '_vscode-openai.editor.code.comment'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     const prompt = await getEditorPrompt('editor.code.comment')
     const persona = getSystemPersonas().find(
       (a) => a.roleName === VSCODE_OPENAI_QP_PERSONA.DEVELOPER
     )
-    await compareResultsToClipboard(persona, prompt)
+    compareResultsToClipboard(persona, prompt)
   }
 }

src/commands/editor/codeExplain.ts

@@ -1,19 +1,19 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { getSystemPersonas } from '@app/models'
 import {
   compareResultsToClipboard,
   getEditorPrompt,
 } from '@app/utilities/editor'
 import { VSCODE_OPENAI_QP_PERSONA } from '@app/constants'
 
-export default class CodeExplainCommand implements Command {
+export default class CodeExplainCommand implements ICommand {
   public readonly id = '_vscode-openai.editor.code.explain'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     const prompt = await getEditorPrompt('editor.code.explain')
     const persona = getSystemPersonas().find(
       (a) => a.roleName === VSCODE_OPENAI_QP_PERSONA.DEVELOPER
     )
-    await compareResultsToClipboard(persona, prompt)
+    compareResultsToClipboard(persona, prompt)
   }
 }

src/commands/editor/codeOptimize.ts

@@ -1,19 +1,19 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { getSystemPersonas } from '@app/models'
 import {
   compareResultsToClipboard,
   getEditorPrompt,
 } from '@app/utilities/editor'
 import { VSCODE_OPENAI_QP_PERSONA } from '@app/constants'
 
-export default class CodeOptimizeCommand implements Command {
+export default class CodeOptimizeCommand implements ICommand {
   public readonly id = '_vscode-openai.editor.code.optimize'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     const prompt = await getEditorPrompt('editor.code.optimize')
     const persona = getSystemPersonas().find(
       (a) => a.roleName === VSCODE_OPENAI_QP_PERSONA.DEVELOPER
     )
-    await compareResultsToClipboard(persona, prompt)
+    compareResultsToClipboard(persona, prompt)
   }
 }

src/commands/editor/codePatterns.ts

@@ -1,19 +1,19 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { getSystemPersonas } from '@app/models'
 import {
   compareResultsToClipboard,
   getEditorPrompt,
 } from '@app/utilities/editor'
 import { VSCODE_OPENAI_QP_PERSONA } from '@app/constants'
 
-export default class CodePatternsCommand implements Command {
+export default class CodePatternsCommand implements ICommand {
   public readonly id = '_vscode-openai.editor.code.pattern'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     const prompt = await getEditorPrompt('editor.code.pattern')
     const persona = getSystemPersonas().find(
       (a) => a.roleName === VSCODE_OPENAI_QP_PERSONA.DEVELOPER
     )
-    await compareResultsToClipboard(persona, prompt)
+    compareResultsToClipboard(persona, prompt)
   }
 }

src/commands/editor/settings.ts

@@ -1,11 +1,11 @@
 import { commands } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 
-export default class SettingsCommand implements Command {
+export default class SettingsCommand implements ICommand {
   public readonly id = '_vscode-openai.editor.settings'
 
-  public async execute(): Promise<void> {
-    await commands.executeCommand(
+  public async execute() {
+    commands.executeCommand(
       'workbench.action.openSettings',
       'vscode-openai.editor.code'
     )

src/commands/embeddings/delete.ts

@@ -1,9 +1,9 @@
 import { window } from 'vscode'
 import { EmbeddingTreeDataProvider, EmbeddingTreeItem } from '@app/providers'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { EmbeddingStorageService } from '@app/services'
 
-export default class RefreshCommand implements Command {
+export default class RefreshCommand implements ICommand {
   public readonly id = '_vscode-openai.embeddings.delete.resource'
   public constructor(private _instance: EmbeddingTreeDataProvider) {}
 

src/commands/embeddings/newConversationEmbedding.ts

@@ -1,10 +1,10 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { IConversation } from '@app/interfaces'
 import { ConversationStorageService } from '@app/services'
 import { EmbeddingTreeItem } from '@app/providers'
 import { getQueryResourcePersona } from '@app/models'
 
-export default class NewConversationEmbeddingCommand implements Command {
+export default class NewConversationEmbeddingCommand implements ICommand {
   public readonly id = 'vscode-openai.embeddings.new.conversation'
 
   public async execute(node: EmbeddingTreeItem) {

src/commands/embeddings/newConversationEmbeddingAll.ts

@@ -1,13 +1,13 @@
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { IConversation } from '@app/interfaces'
 import { ConversationStorageService } from '@app/services'
 import { getQueryResourcePersona } from '@app/models'
 import { VSCODE_OPENAI_EMBEDDING } from '@app/constants'
 
-export default class NewConversationEmbeddingAllCommand implements Command {
+export default class NewConversationEmbeddingAllCommand implements ICommand {
   public readonly id = 'vscode-openai.embeddings.new.conversation-all'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     const persona = getQueryResourcePersona()
     const conversation: IConversation =
       await ConversationStorageService.instance.create(

src/commands/embeddings/newEmbeddingFile.ts

@@ -1,16 +1,16 @@
 import { OpenDialogOptions, window } from 'vscode'
-import { Command } from '@app/commands'
+import { ICommand } from '@app/commands'
 import { EmbeddingStorageService } from '@app/services'
 import {
   createDebugNotification,
   createErrorNotification,
 } from '@app/apis/node'
 import { embeddingResource } from '@app/apis/embedding'
 
-export default class NewEmbeddingFileCommand implements Command {
+export default class NewEmbeddingFileCommand implements ICommand {
   public readonly id = '_vscode-openai.embeddings.new.file'
 
-  public async execute(): Promise<void> {
+  public async execute() {
     // Define the options for the open dialog
     const options: OpenDialogOptions = {
       canSelectMany: true,