Sign/verify implementations using OpenSSL library. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arc-vmware
force-pushed
the
crypto-decoupling-openssl-lib
branch
2 times, most recently
from
7b02ba2 to
16c6c50
Compare
pkthapa
force-pushed
the
openssl-sign-verify
branch
2 times, most recently
from
06b3943 to
6bcf209
Compare
arc-vmware
force-pushed
the
crypto-decoupling-openssl-lib
branch
from
2f9f332 to
efd7b2a
Compare
pkthapa
force-pushed
the
openssl-sign-verify
branch
4 times, most recently
from
8a43b8b to
4f9b348
Compare
pkthapa
force-pushed
the
openssl-sign-verify
branch
2 times, most recently
from
985f38e to
6dc4b49
Compare
pkthapa
force-pushed
the
openssl-sign-verify
branch
6 times, most recently
from
6c81258 to
9e6237f
Compare
nkumar04
reviewed
Jun 17, 2022
nkumar04
reviewed
Jun 17, 2022
nkumar04
reviewed
Jun 17, 2022
nkumar04
reviewed
Jun 21, 2022
nkumar04
reviewed
Jun 21, 2022
nkumar04
reviewed
Jun 21, 2022
nkumar04
reviewed
Jun 21, 2022
tools/KeyfileIOUtils.cpp
Outdated
| @@ -39,17 +39,27 @@ void outputReplicaKeyfile(uint16_t numReplicas, | |||
| << "c_val: " << config.cVal << "\n" | |||
| << "replica_id: " << config.replicaId << "\n" | |||
| << "read-only: " << config.isReadOnly << "\n\n" | |||
| #ifdef USE_CRYPTOPP | |||
| << "# RSA non-threshold replica public keys\n" | |||
| << "rsa_public_keys:\n"; | |||
There was a problem hiding this comment.
Object store integrity checker code look for this "rsa_public_keys" . Please check if we need to make relevant changes there?
pkthapa
force-pushed
the
openssl-sign-verify
branch
from
c9f9870 to
ab57a5a
Compare
added 9 commits
July 14, 2022 15:02
|
@pkthapa, we have already 274 comments in this PR and it's not converging. |
@toly-kournik New PR created here: #12 |
pkthapa
force-pushed
the
openssl-sign-verify
branch
2 times, most recently
from
6c91764 to
57c20fe
Compare
i. Compilation macros (USE_CRYPTOPP_RSA and USE_EDDSA_SINGLE_SIGN) for RSA and EdDSA removed. ii. The choice of signing algorithm is now based on the value set in 'replicaMsgSigningAlgo' and 'operatorMsgSigningAlgo' config variables.
pkthapa
force-pushed
the
openssl-sign-verify
branch
from
57c20fe to
9cd5ab7
Compare
Namespace changed to |
arc-vmware
force-pushed
the
crypto-decoupling-openssl-lib
branch
from
60f690d to
f73a522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Overview
The cryptographic algorithm involved in sign/verify operations should be changed to using
OpenSSL's EdDSAalgorithm.i)
Cryptopp RSAsigning and verification are replaced byOpenSSL EdDSAsigning and verification.ii) Encryption and decryption using
AES-256bit Cipher algorithm usingCBCmode implemented using OpenSSL library.iii) Base64 encoding and decoding using OpenSSL library APIs.
iv) Introduced
USE_RELICandUSE_EDDSA_OPENSSLcompilation macros for BLS multi-sig and EdDSA multi-sig implementation.v) Introduced
replicaMsgSigningAlgoandoperatorMsgSigningAlgoconfig flags to hop between RSA, ECDSA and EdDSA signing and verification.Testing Done
i) Gtest for
EdDSA sign/verify,AES-CBC encrypt/decrypt, andBase64 encode/decodeare working for OpenSSL library only. The same gtest cases forCryptopp RSA sign/verify,AES-CBC-256 encrypt/decrypt, andbase64 encoding/decodingare commented.ii) Apollo test cases for OpenSSL library.
iii) Benchmark tool [picobench] added for comparing
EdDSA signing/verificationvsRSA signing/verification.iv) Added missed OpenSSL digest holder test cases.