Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade #100

Merged
merged 13 commits into from
Feb 5, 2024
Merged

Upgrade #100

merged 13 commits into from
Feb 5, 2024

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Feb 1, 2024 •
edited
Loading

Changes introduced with this PR

  • Upgrade package to use golang 1.21.
  • Upgrade package dependencies.
  • Upgrade CI golang and actions.
  • Dry out registry.go error to satisfy goconst linting.

By contributing to this repository, I agree to the contribution guidelines.

@mfleader mfleader marked this pull request as ready for review February 5, 2024 16:49
@mfleader mfleader requested review from webbnh and dbutenhof February 5, 2024 16:51
jaredoconnell
jaredoconnell approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

webbnh
webbnh approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK as far as I can tell. I've got a coding suggestion, though.

webbnh
webbnh approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfleader mfleader merged commit 3bb6343 into main Feb 5, 2024
6 checks passed
@mfleader mfleader deleted the upgrade branch February 5, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@dbutenhof dbutenhof dbutenhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfleader @webbnh @jaredoconnell @dbutenhof