Podman bug (#15)

* seed RNG to create random strings and remove data races

README.md

@@ -1,3 +1,18 @@
 # Arcaflow engine deployer podman
 
-This library is an implementation of the [arcaflow deployer interface](https://github.com/arcalot/arcaflow-engine-deployer) that uses the podman CLI.
+This library is an implementation of the [arcaflow deployer interface](https://github.com/arcalot/arcaflow-engine-deployer) that uses the podman CLI.
+
+## Verified Podman CLI Version
+
+Testing has been performed on this Podman version to validate 
+functionality.
+
+```
+❯ podman version
+Client:       Podman Engine
+Version:      4.5.0
+API Version:  4.5.0
+Go Version:   go1.19.7
+Built:        Fri Apr 14 11:42:56 2023
+OS/Arch:      linux/amd64
+```

config.go

@@ -31,12 +31,16 @@ const (
 )
 
 type Podman struct {
-	Path              string `json:"path"`
-	ContainerName     string `json:"containerName"`
-	CgroupNs          string `json:"cgroupNs"`
-	NetworkMode       string `json:"networkMode"`
-	ImageArchitecture string `json:"imageArchitecture"`
-	ImageOS           string `json:"imageOS"`
+	Path string `json:"path"`
+	// Constant prefix prepended to the randomized container name string.
+	ContainerNamePrefix string `json:"containerNamePrefix"`
+	CgroupNs            string `json:"cgroupNs"`
+	NetworkMode         string `json:"networkMode"`
+	ImageArchitecture   string `json:"imageArchitecture"`
+	ImageOS             string `json:"imageOS"`
+	// The initial integer that is the starting point for a
+	// Random Number Generator's algorithm.
+	RngSeed int64 `json:"rngSeed"`
 }
 
 // Deployment contains the information about deploying the plugin.

connector.go

@@ -2,19 +2,29 @@ package podman
 
 import (
 	"context"
-
+	"fmt"
 	"github.com/docker/docker/api/types/container"
 	log "go.arcalot.io/log/v2"
 	"go.flow.arcalot.io/deployer"
 	args "go.flow.arcalot.io/podmandeployer/internal/argsbuilder"
 	"go.flow.arcalot.io/podmandeployer/internal/cliwrapper"
+	"go.flow.arcalot.io/podmandeployer/internal/util"
+	"math/rand"
+	"sync"
 )
 
 type Connector struct {
-	containerName    string
-	config           *Config
-	logger           log.Logger
-	podmanCliWrapper cliwrapper.CliWrapper
+	containerNamePrefix string
+	config              *Config
+	logger              log.Logger
+	podmanCliWrapper    cliwrapper.CliWrapper
+	rng                 *rand.Rand
+	// Random Number Generator to facilitate the generation
+	// of random strings for the container name suffix.
+	rngSeed int64
+	// The initial integer that is the starting point for a
+	// random number generator's algorithm.
+	lock *sync.Mutex
 }
 
 func (c *Connector) Deploy(ctx context.Context, image string) (deployer.Plugin, error) {
@@ -29,9 +39,10 @@ func (c *Connector) Deploy(ctx context.Context, image string) (deployer.Plugin,
 	containerConfig := c.unwrapContainerConfig()
 	hostConfig := c.unwrapHostConfig()
 	commandArgs := []string{"run", "-i", "-a", "stdin", "-a", "stdout", "-a", "stderr"}
+	containerName := c.NextContainerName(c.containerNamePrefix, 10)
 
 	args.NewBuilder(&commandArgs).
-		SetContainerName(c.containerName).
+		SetContainerName(containerName).
 		SetEnv(containerConfig.Env).
 		SetVolumes(hostConfig.Binds).
 		SetCgroupNs(c.config.Podman.CgroupNs).
@@ -46,7 +57,7 @@ func (c *Connector) Deploy(ctx context.Context, image string) (deployer.Plugin,
 	cliPlugin := CliPlugin{
 		wrapper:        c.podmanCliWrapper,
 		containerImage: image,
-		containerName:  c.containerName,
+		containerName:  containerName,
 		config:         c.config,
 		stdin:          stdin,
 		stdout:         stdout,
@@ -93,3 +104,9 @@ func (c *Connector) unwrapHostConfig() container.HostConfig {
 	}
 	return container.HostConfig{}
 }
+
+func (c *Connector) NextContainerName(containerNamePrefix string, randomStrSize int) string {
+	c.lock.Lock()
+	defer c.lock.Unlock()
+	return fmt.Sprintf("%s_%s", containerNamePrefix, util.GetRandomString(c.rng, randomStrSize))
+}