Allow oneof in wait_for #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
approved these changes
Dec 11, 2024
| step: wait | ||
| input: | ||
| wait_time_ms: 0 | ||
| wait_for: !oneof |
There was a problem hiding this comment.
Irrelevant comment -- unavoidable given the YAML syntax ARCA has adapted, but every time I see !oneof that voice in the back of my mind yells "not oneof" and tries to confuse me...
dustinblack
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Fixes #218 by allowing a oneof to create an OR dependency.
By contributing to this repository, I agree to the contribution guidelines.