Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an organization variable for the Python testing matrix entries #25

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Jun 24, 2024

Changes introduced with this PR

This change replaces the hard-coded list of Python versions in the test matrix with a reference to the Arcalot organization variable, ARCALOT_PYTHON_SUPPORTED_VERSIONS.

This PR is waiting for the fix in arcalot/arcaflow-plugin-sdk-python#135 to be released.


By contributing to this repository, I agree to the contribution guidelines.

@webbnh webbnh self-assigned this Jun 24, 2024
@webbnh webbnh force-pushed the ARCALOT_PYTHON_SUPPORTED_VERSIONS branch 7 times, most recently from a8473aa to 91d0403 Compare June 25, 2024 00:22
@webbnh webbnh force-pushed the ARCALOT_PYTHON_SUPPORTED_VERSIONS branch from 91d0403 to edb5181 Compare June 25, 2024 00:26
@webbnh webbnh marked this pull request as ready for review June 25, 2024 00:27
Copy link
Contributor Author

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfleader
Copy link
Member

mfleader commented Jul 1, 2024

I agree it seems good to go once the new release is created for the python sdk.

Copy link

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good once the issue to remove the exclusion is completed following the upcoming release of the Python SDK.

@webbnh webbnh merged commit 28c0ca8 into main Jul 3, 2024
6 checks passed
@webbnh webbnh deleted the ARCALOT_PYTHON_SUPPORTED_VERSIONS branch July 3, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants