Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATP v3 refactor #57

Merged
merged 10 commits into from
Oct 20, 2023
Merged

ATP v3 refactor #57

merged 10 commits into from
Oct 20, 2023

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

I think the design is greatly improved now. It now explicitly handles cases instead of just ignoring errors. And it's more flexible now.

  • Made work start message a runtime message to allow graceful closure instead of error on schema-only executions
    • Allows a client done message or a work start message
  • Allowed multiple simultaneous step executions
  • Improved error reporting
    • Errors are passed to the loop that sends messages from server to client. They can be step fatal or server fatal. Server fatal stops execution, while step fatal just reports the error to the client and keeps running until client done.
  • Fixed deadlocks and race conditions
  • Properly report panics from plugin over protocol.

By contributing to this repository, I agree to the contribution guidelines.

Made work start message a runtime message to allow graceful closure instead of error on schema-only executions

Allowed multiple simultaneous step executions

Improved error reporting

Fixed deadlocks and race conditions
@mfleader mfleader added bug Something isn't working enhancement New feature or request labels Oct 10, 2023
@jaredoconnell jaredoconnell changed the title ATP v2 refactor ATP v3 refactor Oct 12, 2023
@jaredoconnell jaredoconnell merged commit 9573909 into main Oct 20, 2023
3 checks passed
@jaredoconnell jaredoconnell deleted the atp-v2-refactor branch October 20, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants