-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underlying type fix #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once all of Webb's conversations are resolved. Remember to make sure the release is a pre-release. This is a potentially breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this resolves all my comments (I'm not sure that you actually addressed my testing concerns, but the code that they referred to is all gone (I think), so I guess it's all good...).
I have two small comments which you can ignore if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go, unless there's a change to address my previous.
Changes introduced with this PR
'underlying type' == subtype
discriminator_inlined
field toOneOfSchema
to allow users to declare the OneOfSchema's discriminator as a field in their subtype, and give it a default setting offalse
nil
interfaceType
bug whereinterfaceType
is not set when a OneOfSchema is created without using a OneOfSchema constructor (NewOneOfIntSchema[T]()
,NewOneOfStringSchema[T]()
).By contributing to this repository, I agree to the contribution guidelines.