Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Channel Close Behavior #96

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix Channel Close Behavior #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions atp/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ func (c *client) handleStepComplete(runID string, receivedSignals chan schema.In
_, exists := c.runningSignalReceiveLoops[runID]
if exists {
delete(c.runningSignalReceiveLoops, runID)
close(receivedSignals)
}
c.mutex.Unlock()
}
Expand All @@ -227,13 +226,6 @@ func (c *client) Close() error {
return nil
}
c.done = true
// First, close channels that could send signals to the clients
// This ends the loop
for runID, signalChannel := range c.runningSignalReceiveLoops {
c.logger.Infof("Closing signal channel for run ID '%s'", runID)
delete(c.runningSignalReceiveLoops, runID)
close(signalChannel)
}
c.mutex.Unlock()
// Now tell the server we're done.
// Send the client done message
Expand Down