Fix list sub-type type resolution (#141)

* Fix list sub-type type resolution * Wrap line * Added input for field in test * Fix line length
arcalot · Nov 8, 2024 · d4b7c9f · d4b7c9f
1 parent 6dcecbd
commit d4b7c9f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/arcaflow_plugin_sdk/schema.py b/src/arcaflow_plugin_sdk/schema.py
@@ -6787,12 +6787,14 @@ def _resolve_list_annotation(
                 "List type without item type definition encountered, please"
                 " declare your lists like this: typing.List[str]",
             )
+        sub_type = args[0]
+
         new_path = list(path)
         new_path.append("items")
         try:
             return ListType(
                 cls._resolve_abstract_type(
-                    args[0], type_hints, tuple(new_path), scope
+                    sub_type, sub_type, tuple(new_path), scope
                 )
             )
         except Exception as e:

diff --git a/src/arcaflow_plugin_sdk/test_schema.py b/src/arcaflow_plugin_sdk/test_schema.py
@@ -963,9 +963,18 @@ class TestData1:
                 default="", metadata={"id": "test-field", "name": "G"}
             )
             I: typing.Any = None
+            J: typing.List[typing.Dict[str, str]] \
+                = dataclasses.field(default_factory=list)
 
         schema.test_object_serialization(
-            TestData1(A="Hello world!", B=5, C={}, D=[], H=3.14),
+            TestData1(
+                A="Hello world!",
+                B=5,
+                C={},
+                D=[],
+                H=3.14,
+                J=[{"a": "b"}],
+            ),
             self.fail,
         )