-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and Apply CI Lint Checks #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. I don't like all of the new format, but we agreed on black
and flake8
. I see some higher risk changes, like messing with isinstance. If those are well tested, or applied automatically, then it's fine. The CI is passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some higher risk changes, like messing with isinstance.
That's an interesting point, and the answer really depends on the intent of the check.
type(a) is Foo
is True only if a
is actually a Foo()
instance, exactly; whereas isinstance(a, Foo)
is True if a
is a Foo
or a subclass of Foo
.
I think in the context I read, the latter is more appropriate, in which case using type
means that subclassing will break the tests whereas the new isinstance
is resistant to that.
But of course if subclasses need not apply, then type
is better... (I think that's rarely true or appropriate...)
Changes introduced with this PR
black
was removed as a style format checker. At this point, it is only used to converge the code base towardsflake8
acceptance.Almost no style checks nor linting was performed on this repository until now, so this is a big one.
By contributing to this repository, I agree to the contribution guidelines.