Fix publish workflow #129
Merged
Fix publish workflow #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
requested review from
dustinblack,
jaredoconnell,
dbutenhof and
mfleader
webbnh
force-pushed
the
fix-publish-workflow
branch
from
4b612d9 to
e3148e2
Compare
webbnh
force-pushed
the
fix-publish-workflow
branch
from
e3148e2 to
6830059
Compare
|
The new workflow works for both the PR path and the tag path (and, because they both referenced the same commit, all of their statuses are in the "checks" for the PR 🙃). |
dbutenhof
approved these changes
Apr 11, 2024
jaredoconnell
approved these changes
Apr 11, 2024
mfleader
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This PR fixes a breakage introduced in #120 in which the
publishjob in the CI workflow tries to reference the build artifact using one of the matrix values, but these are only valid in thebuildjob. This problem only occurs when building tagged commits, e.g., for releases.This PR references
vars.ARCALOT_PYTHON_VERSIONinstead, so that we have a single, consistent source of truth for the version of Python that we support. This PR also changes direct references to3.9in thebuildworkflow (e.g., in the matrix list and in the conditional around producing the coverage data) to use the variable, as well. Also, this PR adds a conditional around uploading the coverage data, so that we do it only once.By contributing to this repository, I agree to the contribution guidelines.