Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a buffered stdout substitute #136

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Use a buffered stdout substitute #136

merged 2 commits into from
Aug 15, 2024

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

Some programs expect the buffer to be there. This ensures that it is.

By contributing to this repository, I agree to the contribution guidelines.

dbutenhof
dbutenhof approved these changes Aug 15, 2024
View reviewed changes
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely thrilled about merging stdout and stderr this way; however you're not changing that aspect so I guess that's out of scope. 😁

@jaredoconnell jaredoconnell merged commit 6c92834 into main Aug 15, 2024
4 checks passed
@jaredoconnell jaredoconnell deleted the buffered-stdout branch August 15, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@mfleader mfleader Awaiting requested review from mfleader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredoconnell @dbutenhof