Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signals and ATP v2 #98
Signals and ATP v2 #98
Changes from 1 commit
9d1d770
f952174
2e07076
82ab335
00d0a65
be01c85
1849d09
4b2561a
13cc3b3
317986f
c7f0155
b692b72
7b86c6b
91226f9
0edc6e5
f599ad3
a14a04b
ca012ed
21e59bf
9113031
28d95e2
a20b61e
7169c78
7ab7b20
68d0ecd
cce45b7
7cf6628
b68efc1
b13a14b
df69b67
cc2960e
c7d9658
c79cef8
3f467d4
ced8b2b
6a47aae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
2
here looks like a "magic number"...shouldn't that be a symbolic reference to an externally-defined constant? Or, perhaps, the wholeHelloMessage(2, plugin_schema)
expression should be encapsulated in a reference?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should create a version constant.