Improve the Base Units example #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredoconnell
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks for the units documentation. Unfortunately this is in the wrong spot. There is a brief section in https://github.com/arcalot/arcalot.github.io/blob/main/docs/arcaflow/workflows/input.md#units
However, your documentation is better and can replace or augment that section.
rh-tguittet
changed the title
|
Moved the example to the pointed location. |
jaredoconnell
approved these changes
Jan 7, 2025
jaredoconnell
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Document how to use Units to use shorthand for durations (
5m30s) and bytes (4GB)I am not sure if this is the right place/file to document it but it really should be documented somewhere :)
By contributing to this repository, I agree to the contribution guidelines.