Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for math, comparisons, and functions #73

Merged
merged 9 commits into from
Mar 6, 2024

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

This is the PR for the documentation for the expressions.
I'd recommend you view the rich version of markdown.

I tried to not be too excessive with the explanation for each type. Let me know if anything is confusing, or not explained enough. If if you find any typos.


By contributing to this repository, I agree to the contribution guidelines.

docs/arcaflow/contributing/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/contributing/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/contributing/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
webbnh

This comment was marked as resolved.

jaredoconnell

This comment was marked as resolved.

@jaredoconnell jaredoconnell marked this pull request as draft February 5, 2024 22:25
@jaredoconnell
Copy link
Contributor Author

I'm going to leave this in draft state until we define the functions, because I think they will be important for the documentation. And also because this isn't added to the engine yet. However, reviews can still occur.

docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/contributing/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/contributing/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
webbnh

This comment was marked as resolved.

@jaredoconnell jaredoconnell marked this pull request as ready for review February 13, 2024 23:51
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
webbnh

This comment was marked as resolved.

webbnh

This comment was marked as resolved.

@webbnh webbnh force-pushed the functions-math-and-comparisons branch from 2cb1df0 to 9cfa6af Compare March 5, 2024 22:40
Copy link
Contributor

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, direct comments only: I'll have to go through the base PR again.

docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
docs/arcaflow/workflows/expressions.md Outdated Show resolved Hide resolved
@mfleader mfleader self-requested a review March 6, 2024 16:47
Copy link
Contributor Author

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new changes look good.

@webbnh webbnh merged commit ed57a65 into main Mar 6, 2024
4 checks passed
@webbnh webbnh deleted the functions-math-and-comparisons branch March 6, 2024 18:35
@webbnh webbnh mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants