Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config-provided allowlist for ignore_bots instead of flat boolean on bot construction #226

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Add config-provided allowlist for ignore_bots instead of flat boolean on bot construction #226

merged 2 commits into from
Oct 13, 2022

Conversation

gregdan3
Copy link
Contributor

Merges after #225

This one's super silly. Important changes are at bottom of modules/init.rb. Tested and works as intended.

I really like ruby's monkeypatching mechanics though! Far better than Python's, ha.

anna328p
anna328p requested changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@anna328p anna328p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you only want the one last commit in this PR, not also the three adding the voicekick command?

@gregdan3 gregdan3 force-pushed the ignore-bots-allowlist branch from 580233b to 2799331 Compare October 13, 2022 02:17
@gregdan3 gregdan3 force-pushed the ignore-bots-allowlist branch from 2799331 to 95e263e Compare October 13, 2022 02:28
@gregdan3
Copy link
Contributor Author

I assume you only want the one last commit in this PR, not also the three adding the voicekick command?

Corrected this.

@anna328p
Copy link
Collaborator

oh, linter is complaining

@anna328p
Copy link
Collaborator

should probably suppress Style/OptionalBooleanParameter here because we don't want to change the API
the other lints are valid though

@gregdan3
Copy link
Contributor Author

lints fixed!

fun bit: it also complains about having a comment on a def line, so it has to be two extra lines surrounding the def instead of one ending it.

@anna328p
Copy link
Collaborator

i've run into that a bunch of times too...

@anna328p anna328p merged commit 3448d07 into arch-community:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna328p anna328p anna328p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregdan3 @anna328p