Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test branch for declarations files #30

Closed
wants to merge 48 commits into from

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Sep 5, 2024

I get this as wanted if I use the wrong type imported in lingo:

arches_lingo/src/arches_lingo/components/tree/ConceptTree.vue:242:17 - error TS2322: Type 'string' is not assignable to type 'number'.

242                 life: ERROR,
                    ~~~~

Base automatically changed from jtw/primevue-4 to main September 5, 2024 20:09
@chrabyrd
Copy link
Contributor

chrabyrd commented Sep 5, 2024

Unfortunately this doesn't look to fix the error for me.

Branches:
arches git:(dev/8.0.x)
arches-lingo git:(jtw/concept-routes)
arches-references git:(jtw/declarations-redux)

All branches are up-to-date. One thing to sanity check, have you removed node_modules from arches-references on your local?

Found 24 errors in 5 files.

Errors  Files
     1  arches_lingo/src/arches_lingo/components/tree/TreeRow.vue:17
     1  arches_lingo/src/arches_lingo/pages/BasicSearch.vue:47
    20  ../arches-references/arches_references/src/arches_references/components/tree/PresentationControls.vue:3
     1  ../arches-references/arches_references/src/arches_references/constants.ts:1
     1  ../arches-references/arches_references/src/arches_references/utils.ts:3

@jacobtylerwalls
Copy link
Member Author

I've been nuking and rebuilding arches-references/node_modules. If I nuke it and don't rebuild it, I do get completely different results (20+ errors with the * path and 5 errors with the .declarations.d.ts path). And the js-cookie error starts appearing 🍪

@chrabyrd
Copy link
Contributor

chrabyrd commented Sep 5, 2024

I've been nuking and rebuilding arches-references/node_modules. If I nuke it and don't rebuild it, I do get completely different results (20+ errors with the * path and 5 errors with the .declarations.d.ts path). And the js-cookie error starts appearing 🍪

Ahhh that's it then. We can assume someone using an Arches application will not run npm install inside the application. Should I reopen the couple of core tickets I had then?

@jacobtylerwalls jacobtylerwalls deleted the jtw/declarations-redux branch September 5, 2024 21:02
@jacobtylerwalls jacobtylerwalls removed the request for review from chrabyrd September 5, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants