Cope with serializer format change #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Feb 12, 2025
| @@ -41,6 +42,14 @@ def validate_appellative_status(self, data): | |||
|
|
|||
| return data | |||
|
|
|||
| @staticmethod | |||
| def get_reference_object(data) -> Reference: | |||
| # TODO: serializer should just do this itself, only waiting to tackle: | |||
There was a problem hiding this comment.
Glad we got the ball rolling on this, now this is moving up higher on my priority list to find a sane generic place to do these transformations.
jacobtylerwalls
force-pushed
the
jtw/cope-with-serializer-change
branch
2 times, most recently
from
886ad4c to
a64d3f5
Compare
jacobtylerwalls
force-pushed
the
jtw/cope-with-serializer-change
branch
from
a64d3f5 to
0949e5a
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partner to archesproject/arches-controlled-lists#63
Existing functionality seems to work okay, but you can also now post back an array of list item ids as we discussed.