Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contracts: execute_condition & execute_function return structs #1315

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

bchamagne
Copy link
Contributor

@bchamagne bchamagne commented Nov 7, 2023

Description

Every functions that executes a contract now returns a struct.
This allow for the playground to display the errors from condition/public function.

It also prepare the ground for the logs and for the validation errors (in 2 next PRs)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with the playground (branch: develop)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added smart contracts Involve smart contracts enhancements labels Nov 7, 2023
@bchamagne bchamagne added this to the 1.5.0 milestone Nov 30, 2023
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested with dex, it works as expected (just need to rebase develop to take last commits that solved some encoding bugs)

@Neylix Neylix merged commit 7fdd7c9 into archethic-foundation:develop Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants