Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default RPC Timeout to 30s #1338

Merged

Conversation

bchamagne
Copy link
Contributor

Description

Default timeout set to 30s instead of 5s
Fixes #1336

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

not tested 👼

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the bug Something isn't working label Nov 30, 2023
@bchamagne bchamagne added this to the 1.4.1 milestone Nov 30, 2023
@bchamagne bchamagne requested a review from redDwarf03 November 30, 2023 16:30
Copy link
Member

@redDwarf03 redDwarf03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be tested in testnet because not reproductive in local env

@bchamagne bchamagne merged commit 88c6ff1 into archethic-foundation:release/1.4.1 Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants