Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network patch with negative eigen value #1639

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 20, 2025

Description

Fixes an issue where in certain case (low number of nodes and low latencies) the eigen values calulated during network patch algo was negative causing a NaN value after.

Fixed it using the absolute value of the eigen value.

Also added default value for the network patch to avoid serialization issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested using this matrix:

[
   [0, 18, 3],
   [18, 0, 2],
   [3, 2, 0]
]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Jan 20, 2025
@Neylix Neylix force-pushed the Fix-network-patch branch from 986c6de to da9cc3f Compare January 20, 2025 14:15
@Neylix Neylix merged commit 4ed4292 into archethic-foundation:develop Jan 20, 2025
1 of 2 checks passed
@Neylix Neylix deleted the Fix-network-patch branch January 20, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant