Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node rewards issue #1655

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 3, 2025

Description

Fixes an issue when validating the node_rewards transaction. The UTXO used to calculate the transfers are retrieved locally therefore if a node missed the last mint_reward transaction, its UTXO will not be the same and so the transaction will fail.
Fixed it by fetching UTXO instead to get them locally.
Also sorted the nodes to ensure all nodes has the same transfer order

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working rewards labels Feb 3, 2025
@Neylix Neylix merged commit a60e80c into archethic-foundation:develop Feb 3, 2025
1 of 2 checks passed
@Neylix Neylix deleted the Fix-rewards branch February 3, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant