Add DataObjectListener test

src/DataObjectEventListener.php → src/Listener/DataObjectEventListener.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace ArchiPro\Silverstripe\EventDispatcher;
+namespace ArchiPro\Silverstripe\EventDispatcher\Listener;
 
 use ArchiPro\EventDispatcher\ListenerProvider;
 use ArchiPro\Silverstripe\EventDispatcher\Event\DataObjectEvent;

tests/php/Extension/EventDispatchExtensionTest.php

@@ -2,9 +2,9 @@
 
 namespace ArchiPro\Silverstripe\EventDispatcher\Tests\Extension;
 
-use ArchiPro\Silverstripe\EventDispatcher\DataObjectEventListener;
 use ArchiPro\Silverstripe\EventDispatcher\Event\DataObjectEvent;
 use ArchiPro\Silverstripe\EventDispatcher\Event\Operation;
+use ArchiPro\Silverstripe\EventDispatcher\Listener\DataObjectEventListener;
 use ArchiPro\Silverstripe\EventDispatcher\Tests\Mock\SimpleDataObject;
 use ArchiPro\Silverstripe\EventDispatcher\Tests\Mock\VersionedDataObject;
 use Revolt\EventLoop;

tests/php/Listener/DataObjectEventListenerTest.php

@@ -0,0 +1,148 @@
+<?php
+
+namespace ArchiPro\Silverstripe\EventDispatcher\Tests\Listener;
+
+use ArchiPro\EventDispatcher\ListenerProvider;
+use ArchiPro\Silverstripe\EventDispatcher\Event\DataObjectEvent;
+use ArchiPro\Silverstripe\EventDispatcher\Event\Operation;
+use ArchiPro\Silverstripe\EventDispatcher\Listener\DataObjectEventListener;
+use ArchiPro\Silverstripe\EventDispatcher\Tests\Mock\SimpleDataObject;
+use ArchiPro\Silverstripe\EventDispatcher\Tests\Mock\VersionedDataObject;
+use PHPUnit\Framework\MockObject\MockObject;
+use SilverStripe\Dev\SapphireTest;
+use SilverStripe\ORM\DataObject;
+
+/**
+ * Tests for DataObjectEventListener to verify:
+ * - Event filtering by class inheritance
+ * - Event filtering by operation types
+ * - Callback execution
+ */
+class DataObjectEventListenerTest extends SapphireTest
+{
+    protected static $extra_dataobjects = [
+        SimpleDataObject::class,
+        VersionedDataObject::class,
+    ];
+
+    private array $receivedEvents = [];
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->receivedEvents = [];
+    }
+
+    public function testListenerFiltersByClass(): void
+    {
+        // Create listener that only handles SimpleDataObject events
+        $listener = DataObjectEventListener::create(
+            function (DataObjectEvent $event) {
+                $this->receivedEvents[] = $event;
+            },
+            [SimpleDataObject::class]
+        );
+
+        // Should handle SimpleDataObject event
+        $simpleEvent = DataObjectEvent::create(1, SimpleDataObject::class, Operation::CREATE);
+        $listener($simpleEvent);
+        $this->assertCount(1, $this->receivedEvents, 'Listener should handle SimpleDataObject events');
+
+        // Should not handle VersionedDataObject event
+        $versionedEvent = DataObjectEvent::create(1, VersionedDataObject::class, Operation::CREATE);
+        $listener($versionedEvent);
+        $this->assertCount(1, $this->receivedEvents, 'Listener should not handle VersionedDataObject events');
+    }
+
+    public function testListenerHandlesInheritedClasses(): void
+    {
+        // Create listener that handles all DataObject events
+        $listener = DataObjectEventListener::create(
+            function (DataObjectEvent $event) {
+                $this->receivedEvents[] = $event;
+            },
+            [DataObject::class]
+        );
+
+        // Should handle both SimpleDataObject and VersionedDataObject events
+        $simpleEvent = DataObjectEvent::create(1, SimpleDataObject::class, Operation::CREATE);
+        $versionedEvent = DataObjectEvent::create(1, VersionedDataObject::class, Operation::CREATE);
+
+        $listener($simpleEvent);
+        $listener($versionedEvent);
+
+        $this->assertCount(2, $this->receivedEvents, 'Listener should handle events from DataObject subclasses');
+    }
+
+    public function testListenerFiltersByOperation(): void
+    {
+        // Create listener that only handles CREATE and UPDATE operations
+        $listener = DataObjectEventListener::create(
+            function (DataObjectEvent $event) {
+                $this->receivedEvents[] = $event;
+            },
+            [SimpleDataObject::class],
+            [Operation::CREATE, Operation::UPDATE]
+        );
+
+        // Should handle CREATE event
+        $createEvent = DataObjectEvent::create(1, SimpleDataObject::class, Operation::CREATE);
+        $listener($createEvent);
+        $this->assertCount(1, $this->receivedEvents, 'Listener should handle CREATE events');
+
+        // Should handle UPDATE event
+        $updateEvent = DataObjectEvent::create(1, SimpleDataObject::class, Operation::UPDATE);
+        $listener($updateEvent);
+        $this->assertCount(2, $this->receivedEvents, 'Listener should handle UPDATE events');
+
+        // Should not handle DELETE event
+        $deleteEvent = DataObjectEvent::create(1, SimpleDataObject::class, Operation::DELETE);
+        $listener($deleteEvent);
+        $this->assertCount(2, $this->receivedEvents, 'Listener should not handle DELETE events');
+    }
+
+    public function testListenerHandlesAllOperationsWhenNotSpecified(): void
+    {
+        // Create listener without specifying operations
+        $listener = DataObjectEventListener::create(
+            function (DataObjectEvent $event) {
+                $this->receivedEvents[] = $event;
+            },
+            [SimpleDataObject::class]
+        );
+
+        // Should handle all operations
+        foreach (Operation::cases() as $operation) {
+            $event = DataObjectEvent::create(1, SimpleDataObject::class, $operation);
+            $listener($event);
+        }
+
+        $this->assertCount(
+            count(Operation::cases()),
+            $this->receivedEvents,
+            'Listener should handle all operations when none specified'
+        );
+    }
+
+    public function testSelfRegister(): void
+    {
+        // Create a mock event service
+        /** @var MockObject|ListenerProvider $provider */
+        $provider = $this->createMock(ListenerProvider::class);
+        $provider->expects($this->once())
+            ->method('addListener')
+            ->with(
+                DataObjectEvent::class,
+                $this->isInstanceOf(DataObjectEventListener::class)
+            );
+
+        // Create listener and register with mock service
+        $listener = DataObjectEventListener::create(
+            function (DataObjectEvent $event) {
+                $this->receivedEvents[] = $event;
+            },
+            [SimpleDataObject::class]
+        );
+        $listener->selfRegister($provider);
+    }
+}