Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hebrew translation. #2348

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Added Hebrew translation. #2348

merged 3 commits into from
Mar 7, 2024

Conversation

yarons
Copy link
Contributor

@yarons yarons commented Jan 24, 2024

PR Description:

Adding base.po and base.mo in Hebrew (Full translation).

Tests and Checks

  • I have tested the code!

Tested on a virtual machine and found several issues described in #2347, but having the complete translation will motivate fixing those :)

@yarons yarons requested a review from Torxed as a code owner January 24, 2024 05:34
@yarons
Copy link
Contributor Author

yarons commented Jan 24, 2024

There's some error regarding a missing license file. Is there anything I can do to fix it?

@yarons
Copy link
Contributor Author

yarons commented Jan 24, 2024

I've accidentally added the README change to this branch, I'll start over if needed, sorry about that.

README.md Show resolved Hide resolved
@svartkanin
Copy link
Collaborator

That's okay, I left a small comment

Restored the required instruction.
@svartkanin
Copy link
Collaborator

Great, I don't have merging power so we have to wait for @Torxed

@Torxed Torxed merged commit fbc005d into archlinux:master Mar 7, 2024
6 checks passed
@yarons
Copy link
Contributor Author

yarons commented Mar 7, 2024

Thank you so much!
BTW I've observed some issues with the Linux native console (the text is reversed), fbterm looks better but I'm looking for a better-supported console solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants