Always revert queue worker to the central context — fix #1229 #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancl
changed the title
|
@pr4xx Sorry about the delay on this, could you test the queue bootstrapper version from this PR? |
|
@stancl Thanks for the update. I deployed your version of the QueueTenancyBootstrapper to the testing environment and after a few short tests, it seems to work fine. I will report back after some more days of testing. |
|
@stancl Some time has passed and had no issue with the updated code in production. |
|
Awesome, thanks for all the help with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the QueueTenancyBootstrapper to always revert back to the previous context. In practice, this means reverting back to the central context unless
dispatchNow()was used.This addresses the issue described in #1229 where if the queue worker stayed in the tenant context, it would not respond to queue:restart signals.
The
$forceRefreshstatic property is now unused and deprecated.v4 will simplify the bootstrapper further since there are fewer backwards compatibility concerns.