Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacs readiness #40

Merged
merged 6 commits into from
Nov 24, 2024
Merged

Hacs readiness #40

merged 6 commits into from
Nov 24, 2024

Conversation

msp1974
Copy link
Collaborator

@msp1974 msp1974 commented Nov 23, 2024

References #44

@ardevd
Copy link
Owner

ardevd commented Nov 23, 2024

Does HACS require/prefer releases being handled this way? (through release asset zip files?). I thought HACs just checked out from git directly and used tags to track versioning?

@ardevd
Copy link
Owner

ardevd commented Nov 23, 2024

I've submitted a PR to the brands repo

@ardevd ardevd self-requested a review November 23, 2024 20:32
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@msp1974
Copy link
Collaborator Author

msp1974 commented Nov 24, 2024

Does HACS require/prefer releases being handled this way? (through release asset zip files?). I thought HACs just checked out from git directly and used tags to track versioning?

I do this with some of my other integrations. Cant quite remember why. But it is better to do releases than just tags.

@ardevd ardevd merged commit 8bf5802 into main Nov 24, 2024
5 checks passed
@ardevd ardevd deleted the hacs-readiness branch November 24, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants