patch: expose all engines #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that only the Scalar engine was exposed
verpeteren
added a commit
to verpeteren/rust-simd-noise
that referenced
this pull request
Nov 19, 2024
I finished the port to simdeez2 with the help of @valadaptive and @arduano 🎉 This PR needs more engines in the simdeez library exposed. Hence [this PR](arduano/simdeez#74). Because there were some bugfixes along the way, the output of the various noise generators might slightly differ. There are probably things that are slightly broken and the _f64 variants were done on a best effort basis. Let's merge this in and improve from there!
|
Yeah so this one was difficult for me to decide on. The issue with exposing all engines is that the API is no longer safe. The reason the API was all The requirement: If the programmer can explicitly specify the engine they're currently using for any given piece of code, the programmer must known the operation is going to be unsafe (should result in at least 1 unsafe block somewhere in their code). Manually choosing an engine is inherently unsafe because the CPU may not support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that only the Scalar engine was exposed