Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClient implements inherited
Client::connect(IPAddress ip, uint16_t port)
andClient::connect(const char *host, uint16_t port)
. The existing implementation is to simple: it does not update internal state variablesiServerName
,iServerAddress
andiServerPort
, but just invokes the wrapped client. This causes subsequent requests to be incorrect (e.g. wronghost
header).This PR changes
connect
to also update state.