Basic authentication for web socket

[biohazardious]

I added basic authentication for web socket.

[sandeepmistry]

Hi @biohazardious,

First of all, many thanks for submitting this pull request!

What do you think about adding a void sendBasicAuth(const char* aUser, const char* aPassword); method like in HttpClient instead of adding a new begin(...) signatures?

It also appears some of the whitespace in your changes is not consistent with the existing code base.

[biohazardious]

Hi @sandeepmistry ,

I added new begin signatures because unlike HttpClient REST methods, you should send authentication data while creating socket. That's why i modified begin function.

PS: sorry for whitespaces, it was a quick fix those was my mistake.

[sandeepmistry]

Hi @biohazardious,

Ok, got it so sendBasicAuth is not the best name. An alternative is what we have in the MQTT Cient library: https://github.com/arduino-libraries/ArduinoMqttClient/blob/master/src/MqttClient.h#L85

setUsernamePassword or setBasicAuth - this is something you would call before begin.

[CLAassistant]

All committers have signed the CLA.