Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ServerAddress for Host header #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lehecka
Copy link

@lehecka lehecka commented Mar 13, 2020

The HttpClient can be initialized with a ServerName(string) or ServerAddress (IPAddress). In the first case the underlaying Client will use DNS lookup to translate the name to the IP address. This lookup code is consuming extra bytes in memory. When making the HTTP request the ServerName is used for Host header.
If the ServerAddress is specified in the ctor of the HttpClient then the HTTP requests are missing the Host header.

In this diff the user has ability to call useServerAddressForHostHeader to use the ServerAddress for the Host header.

As a workaround without this fix one has to use sendHeader / beginBody / endRequest call which makes the API use very cumbersome and error prone .

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants