Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add umbrella header file that matches lib name #20

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

sebromero
Copy link
Contributor

Solves #3 by adding an umbrella header that matches the library name as desired by Arduino Lint.
The old header is left in place for the time being to ensure backwards compatibility. To avoid clashes in sketches using this library, they can now refer to this new header file.

Copy link

Memory usage change @ 0888c22

Board flash % RAM for global variables %
arduino:mbed_nicla:nicla_vision 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BasicUsage
flash
% examples/BasicUsage
RAM for global variables
% examples/ReadWriteRegs
flash
% examples/ReadWriteRegs
RAM for global variables
%
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/BasicUsage<br>flash,%,examples/BasicUsage<br>RAM for global variables,%,examples/ReadWriteRegs<br>flash,%,examples/ReadWriteRegs<br>RAM for global variables,%
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 11, 2023
@per1234 per1234 linked an issue Dec 11, 2023 that may be closed by this pull request
Copy link
Collaborator

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sebromero sebromero merged commit c08f3da into master Dec 12, 2023
11 of 13 checks passed
@sebromero sebromero deleted the umbrella-header branch December 12, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header file conflict with BQ24195 library
3 participants