fix: warning no return statement in function returning non-void

[hideakitai]

Fixed the warning below by returning void instead of int because none of the related functions return anything.

In file included from Arduino_PF1550/src/PF1550.cpp:28:0:
Arduino_PF1550/src/PF1550/PF1550_IO_Portenta_H7.h: In member function 'virtual int PF1550_IO_Portenta_H7::derived_begin()':
Arduino_PF1550/src/PF1550/PF1550_IO_Portenta_H7.h:40:42: warning: no return statement in function returning non-void [-Wreturn-type]
   virtual int derived_begin() override { }
                                          ^

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Memory usage change @ c80c0cf

Board	flash	%	RAM for global variables	%
arduino:mbed_nicla:nicla_vision	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A
arduino:mbed_portenta:envie_m7:target_core=cm4	N/A	N/A	N/A	N/A
arduino:renesas_portenta:portenta_c33	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/BasicUsage flash	%	examples/BasicUsage RAM for global variables	%	examples/ReadWriteRegs flash	%	examples/ReadWriteRegs RAM for global variables	%
arduino:mbed_nicla:nicla_vision	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
arduino:mbed_portenta:envie_m7:target_core=cm4	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
arduino:renesas_portenta:portenta_c33	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/BasicUsage<br>flash,%,examples/BasicUsage<br>RAM for global variables,%,examples/ReadWriteRegs<br>flash,%,examples/ReadWriteRegs<br>RAM for global variables,%
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7:target_core=cm4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0

[aentinger]

Hi @hideakitai ☕ 👋

Instead of eliminating the return value altogether I think it makes more sense to also return the return code of _wire->begin(); and _wire->setClock(100000); in case there's an error. Can you please adjust this PR to that end?

[hideakitai]

@aentinger Thanks. I think both arduino::HardwareI2C (and TwoWire) 's begin() and setClock() returns void, so I made it void. If I have any misunderstandings, please let me know.

• https://github.com/arduino/ArduinoCore-API/blob/331cdd9ad216941cc2dedefa51fe643d1c4f0ac2/api/HardwareI2C.h#L29-L33
• https://github.com/arduino/ArduinoCore-avr/blob/63092126a406402022f943ac048fa195ed7e944b/libraries/Wire/src/Wire.h#L53-L57

[hideakitai]

@aentinger What should I do about this one?

[hideakitai]

Terminate this PR because there is no reaction from reviewer @aentinger