Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cmake-single-platform.yml #210

Closed
wants to merge 1 commit into from

Conversation

zifiri99
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@per1234 per1234 self-assigned this Jun 15, 2024
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jun 15, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zifiri99. Thanks for taking the time to submit a pull request.

As you can see from the workflow run logs:

https://github.com/arduino-libraries/NTPClient/actions/runs/9530782946/job/26271033621?pr=210#step:3:7

Run cmake -B /home/runner/work/NTPClient/NTPClient/build -DCMAKE_BUILD_TYPE=Release
CMake Error: The source directory "/home/runner/work/NTPClient/NTPClient" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.

this project is not configured for building with CMake. We also don't have any interest in adding such a capability since we only provide official support for using the library with the official development tools provided by Arduino (Arduino IDE, Arduino CLI, Arduino Cloud Editor).

So I'll close this pull request as declined.

@per1234 per1234 closed this Jun 15, 2024
@per1234 per1234 added the conclusion: declined Will not be worked on label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants