Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods for working with Date component #60

Closed
wants to merge 3 commits into from

Conversation

iPhosgen
Copy link

Added methods for working with Date component

@MrTanoshii
Copy link

I believe the build check failed because you forgot to add #include <time.h>

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 12, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request @iPhosgen. I don't think it is a good idea to add a function that returns an arbitrary ambiguous date format (DD.MM.YYYY) since this would only be useful to those who happen to prefer that format (unfortunately there is an inconsistency in how dates are formatted from one locale to another and from one individual to another), and potentially confusing to those who are accustomed to another format.

If such a function is to be added, it should either support returning the date in any user specified format as proposed in #94, or else use an ISO 8601 standard format as proposed in #119 and #195

@per1234 per1234 self-assigned this Sep 10, 2023
@per1234 per1234 closed this Sep 10, 2023
@per1234 per1234 added the conclusion: declined Will not be worked on label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: declined Will not be worked on topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants