Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to ascii #206

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Test to ascii #206

merged 1 commit into from
Sep 8, 2023

Conversation

jboynes
Copy link
Contributor

@jboynes jboynes commented Sep 7, 2023

Fix for #197 by removing undef of _GNU_SOURCE.
Change includes PR #205 so I can run the test suite reliably.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e9d4d01) 95.61% compared to head (1e6d3f1) 95.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          14       14           
  Lines        1048     1048           
=======================================
  Hits         1002     1002           
  Misses         46       46           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@per1234 per1234 linked an issue Sep 7, 2023 that may be closed by this pull request
@per1234 per1234 added the bug label Sep 7, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Compiling of the test cases under C++20 is not terribly relevant to us, but since it also works w/ C++11 (under which our CI tests run) AND because its test code I'll allow this in.

@aentinger aentinger merged commit ebe1fab into arduino:master Sep 8, 2023
@jboynes jboynes deleted the test_toAscii branch September 8, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error compiling test_toAscii.cpp with higher language level
4 participants