Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API credentials URL in credentials init message #144

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Update API credentials URL in credentials init message #144

merged 1 commit into from
Dec 20, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Dec 16, 2023

Motivation

The arduino-cloud-cli credentials init command prints a helpful message providing the user with guidance about how to obtain the Arduino Cloud API credentials.

It seems the URL of the Arduino Cloud API Keys page changed due to restructuring of the site since the time this message was written. A redirect was not set up from the old URL to the new URL so the previous URL in the message now only redirects to the Arduino Cloud home page:

To obtain your API credentials visit https://create.arduino.cc/iot/integrations

Change description

The URL is hereby updated to the modern URL of the API Keys page: https://app.arduino.cc/api-keys

Additional Notes

Although the incorrect/missing redirect should also be fixed, it is still best to avoid a reliance on such redirects since they tend to be ephemeral.

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

The `arduino-cloud-cli credentials init` command prints a helpful message providing the user with guidance about how to
obtain the Arduino Cloud API credentials.

The URL of the Arduino Cloud API Keys page changed during a recent restructuring of the site. A redirect was not set up
from the old URL to the new URL so the previous URL in the message now only redirects to the Arduino Cloud home page:

> To obtain your API credentials visit https://create.arduino.cc/iot/integrations

Although the incorrect/missing redirect should be fixed, it is still best to avoid a reliance on such redirects since
they tend to be ephemeral.

The URL is hereby updated to the modern URL of the API Keys page.
@per1234 per1234 added the bug Something isn't working label Dec 16, 2023
@per1234
Copy link
Contributor Author

per1234 commented Dec 18, 2023

To the reviewer(s), I don't have the necessary permissions to merge this, so please merge it once/if it has received sufficient approval.

CC: @mirkokurt

@mirkokurt mirkokurt merged commit 3e54c17 into arduino:main Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants