Skip to content

Use engines.node as source of version data for "actions/setup-node" action #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Mar 12, 2025

A single standardized version of Node.js is used for all development work in this repository, both by contributors and the automated validation systems.

The actions/setup-node GitHub Actions action is used to set up Node.js in the GitHub Actions runner machine.

The action supports obtaining the Node.js version to set up from the engines.node field of the package.json file:

https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file

This allows us to define the standardized version of Node.js for use by project contributors in a single place rather than having to maintain multiple instances of that data.

per1234 added 2 commits March 12, 2025 05:45
These variables were used in the system that configures the task to use version 3.3.0 of ajv-cli instead of the standard
project version. That system is no longer needed, and so has been removed. The variables were not removed at that time.
The actions/setup-node GitHub Actions action is used to set up Node.js in the GitHub Actions runner machine.

The action supports obtaining the Node.js version to set up from the `engines.node` field of the package.json file.

This allows us to define the standardized version of Node.js for use by project contributors in a single place rather
than having to maintain multiple instances of that data.
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Mar 12, 2025
@per1234 per1234 self-assigned this Mar 12, 2025
@per1234 per1234 merged commit 3f582fd into arduino:master Mar 12, 2025
28 checks passed
@per1234 per1234 deleted the engine branch March 12, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant