Added mDNS support for AP interface #40
Conversation
Added mDNS support for AP interface to allow the hostname management when AP configuration is enabled
| @@ -206,6 +206,12 @@ CONFIG_EFUSE_MAX_BLK_LEN=192 | |||
| # ESP32-specific | |||
| # | |||
| CONFIG_IDF_TARGET_ESP32=y | |||
| CONFIG_ESP32_REV_MIN_0=y | |||
There was a problem hiding this comment.
Which IDF are you using? If it's an IDF update, it should be an independent commit.
There was a problem hiding this comment.
Are these all the default values?
There was a problem hiding this comment.
yes is the one we suggest on the install on the read me, maybe i enable unvolontarly i'm work to remove it
| @@ -697,6 +703,15 @@ void WiFiClass::handleSystemEvent(system_event_t* event) | |||
| case SYSTEM_EVENT_AP_START: { | |||
| struct netif* apNetif; | |||
|
|
|||
| mdns_init(); | |||
There was a problem hiding this comment.
Are you sure this mdns_init is needed? I believe without it macOS was fine in STA mode, should we also port to STA mode?
There was a problem hiding this comment.
As described by the example seems yes, its recommend by the example, i had test adding in the properly interface like how we do in STA but not works i had found an issue on the epressif repo.
This is why i suppose to test the mdns and from the result was that works for the access point.
We can try to move on other direction implement in STA mode and removing the interface management if a plus.
There was a problem hiding this comment.
There was a problem hiding this comment.
As i understand when the AP interface is used we should enable a dns local instance because we don't have a reference DNS Server like the STA (i'm testing it).
Now i'm try to correctly configure the local dns and ad the feature AS_DYNAMIC in order to be able to manage the lookup table and the new rules if this works we could leave the idea of implement the mdns.
| @@ -705,6 +720,8 @@ void WiFiClass::handleSystemEvent(system_event_t* event) | |||
| } | |||
| } | |||
|
|
|||
| mdns_hostname_set(_hostname); | |||
There was a problem hiding this comment.
What's the difference between mdns_hostname_set and tcpip_adapter_set_hostname?
There was a problem hiding this comment.
mdns_hostname_set set the name on the mdns onject the other goes to set the hostname on the lwip tcpip interface
There was a problem hiding this comment.
maybe the second is useless while mdns is enabled
There was a problem hiding this comment.
in STA mode mdns not works
| // defines required from mdns service | ||
| #define LWIP_MDNS_RESPONDER 1 | ||
| #define LWIP_IGM 1 | ||
| #define LWIP_IPV4 1 |
There was a problem hiding this comment.
It seems really strange we need these defines to be manually added ... are you sure we need them?
There was a problem hiding this comment.
removed!! added on the kconfig
|
closed the issue because the actual behavior match with the one of the mkr1000 |
Added mDNS support for AP interface to allow the hostname management when AP configuration is enabled
cc:/ @facchinm @sandeepmistry test and take a look on the sdkconfig there is somethings of new
i had just make some tests and seems that works fine, i tried also to connect two device in the same time and all goes fine
this fix arduino-libraries/WiFiNINA#92 for 1010, Iot 33 and works also on uno WiFi