Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

426 fix cmake integration by fetching #428

Merged
merged 13 commits into from
Nov 4, 2024
Merged

426 fix cmake integration by fetching #428

merged 13 commits into from
Nov 4, 2024

Conversation

aregtech
Copy link
Owner

@aregtech aregtech commented Nov 4, 2024

Multiple fixes:

  • Fixed build by fetching;
  • Fixe build by "build type" (Debug / Release).
  • Fixed warnings
  • Tested

@aregtech aregtech added bug Something isn't working C++ cmake bugfix labels Nov 4, 2024
@aregtech aregtech requested a review from vukihub November 4, 2024 21:53
@aregtech aregtech self-assigned this Nov 4, 2024
vukihub
vukihub approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@vukihub vukihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@aregtech aregtech merged commit b8d226a into master Nov 4, 2024
37 checks passed
@aregtech aregtech linked an issue Nov 4, 2024 that may be closed by this pull request
Fix cmake integration by fetching #426
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vukihub vukihub vukihub approved these changes

Assignees

@aregtech aregtech

Labels
bug Something isn't working bugfix C++ cmake
Projects
AREG IoT SDK (areg sdk)
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix cmake integration by fetching
2 participants
@aregtech @vukihub