ADBDEV-6811 Throw out fault injector code blocks for release builds #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definition FAULT_INJECTOR is hardcoded in a header(pg_config_manual.h) file. Fault injector is useful, but it may introduce some issues in production stage, like runtime cost, security problems. It's better to enable this feature in development and disable it in release. The --enable-debug-extensions configure option is used to control this feature.
RekGRpth
reviewed
Feb 13, 2025
RekGRpth
reviewed
Feb 13, 2025
RekGRpth
reviewed
Feb 13, 2025
RekGRpth
reviewed
Feb 13, 2025
There was a runaway space and a stale message that didn't match the real flag. Correct those because well, they are wrong, but also because otherwise `autoreconf` and friends refuse to generate configure from configure.in.
This comment was marked as resolved.
This comment was marked as resolved.
|
How do you plan to merge the patch? Rebase or squash? |
corrected |
andr-sokolov
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude fault injector test code for release build. It shall provide better
performance by removing test only code with consequent simplifying of functions
and avoid running sub-optimal test code.
This commit is based on 7.x commit 4111340
Co-authored-by: Hao Wu [email protected]