Famicom/NES - Added SNES-2-NES Controller Adaptor support. #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dout anyone will use it as only a very few bits of homebrew use the extra inputs. But the NES-2-SNES cable is added, all keys work. If anyone wants i can add other controllers but dont think any software supports other add-ons useing this basic cable.
LukeUsher
reviewed
Dec 10, 2023
| @@ -0,0 +1,94 @@ | |||
| SFC_Gamepad::SFC_Gamepad(Node::Port parent) { | |||
There was a problem hiding this comment.
nit: We don't usually use underscores in class names; consider SuperFamicomController, as SFCController looks awkward.
There was a problem hiding this comment.
Make whatever changes you want, dont have time to deal with this right now, personal things are happening in my life and its likey 5 seconds for you anyways....
Same with the other pull request for those Coleco-Vision Mappers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dout anyone will use it as only a very few bits of homebrew use the extra inputs. But the NES-2-SNES cable is added, all keys work.
If anyone wants i can add other controllers other than the "GamePad" one useing this adapter,but yet to see any software that uses them.
The other way is possible but doubtful its worth emulating as it should just work identically to the SFC controller with buttons missing.