Feature/build #42
Merged
Feature/build #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably about time we extracted this one from feature/fixes too. I'll use the result of this in doing the auto-tools part of #4. TODO: first commit in this series is huge, it needs cutting down into commits matching the goals in the description. Order is incorrect too - switching to Now it's separated into distinct goals, I think we may have 1-4 done, 5 is on its way and 6 is pie-in-the-sky but definitely desirable - considering the stretch goal. (we could extend that to system libraries) |
Closed
arfbtwn
force-pushed
the
feature/build
branch
2 times, most recently
from
59e3195 to
e3892c4
Compare
arfbtwn
commented
Sep 10, 2017
| @@ -23,6 +21,9 @@ desktopfiles_files = $(desktopfiles_in_files:.desktop.in=.desktop) | |||
| desktopfilesdir = $(datadir)/applications | |||
| desktopfiles_DATA = $(desktopfiles_files) | |||
|
|
|||
| %.desktop: %.desktop.in | |||
| $(AM_V_GEN)$(MSGFMT) --desktop --template $< -d $(top_srcdir)/po -o $@ | |||
|
|
|||
There was a problem hiding this comment.
I'm not 100% on this update in particular, worth a closer look
arfbtwn
commented
Sep 10, 2017
| @@ -60,20 +60,22 @@ PROFILE_DEFAULT=--profile=log:time=fast,calls,noalloc,maxframes=5 | |||
| PROFILE_HEAP=--profile=logging:heap=all,gc-dumps=-1 | |||
| PROFILE_GUI=--profile=gui-thread-check | |||
|
|
|||
| RUN_DEFAULT=--debug --uninstalled | |||
There was a problem hiding this comment.
I actually wanted to get $* into here, IIRC I tried RUN_DEFAULT='--debug --uninstalled $*' at the time but it didn't work, although I don't recall what was passed through, worth a second look
arfbtwn
force-pushed
the
feature/build
branch
2 times, most recently
from
78fb743 to
0ff8672
Compare
arfbtwn
force-pushed
the
feature/build
branch
from
683c09d to
7aed0ba
Compare
arfbtwn
force-pushed
the
feature/build
branch
4 times, most recently
from
64be04e to
bb0c8da
Compare
arfbtwn
force-pushed
the
feature/build
branch
5 times, most recently
from
c4edbbc to
71ef167
Compare
arfbtwn
force-pushed
the
feature/build
branch
from
71ef167 to
97a9298
Compare
Not really sure why we did this - I think some calculations were off when doing the menu button.
arfbtwn
force-pushed
the
feature/build
branch
from
c104af5 to
97a9298
Compare
There were a number of problems with the NowPlaying extension making its behaviour, particularly with respect to GUI components, a bit confusing. In addition there were a number fo hack comments indicating quality issues. It appears to have suffered some bit-rot as functionality was added and the extension was expanded. We address a number of things: - remove the unused substitute audio display; - make NowPlayingContents default home in NowPlayingInterface; - remove all unnecessary graphical programming; - remove the OnShown timeout hack; - re-work going fullscreen and back. Finally we prevent background pattern clearing in the Gdk.Window we ask GStreamer to draw on, this causes an XLib error on reparenting when the HeaderBar is in use in the lite interface and the only reason I can find for clearing the property is the original GStreamer C example code for the video overlay.
This commit removes the ENABLE_TESTS define from B.WebBrowser to avoid compilation errors from the NUnit shipped with mono, we'll need to move NUnit to become a NuGet installable component.
leave the GETTEXTDATADIR commented out - prevents translation generation regenerating the file names and stripping the ../ prefix.
arfbtwn
force-pushed
the
feature/build
branch
from
97a9298 to
a14fa80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues the current build system:
autogen.shis required becauseautoreconfdoes not work;intltool, which is deprecated;./configureoften fails for optional dependencies; (although it does provide resolution instructions)*.m4file has custom style and implementation, raising the bar for new developers;Goals:
autoreconf -fvishould produce a workingconfigurescript;*.m4files;./configureshould succeed if base dependencies are satisfied; (or can be configured with internal facsimilies)./configureshould enable all optional components where dependencies are satisfied;./configureshould configure solution and project files. e.g triviallyLIBMTP_SIZEOF_T_64but also the solution file build configuration.Stretch: