Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more tests related to untested error messages #54

Merged
merged 17 commits into from
Jul 1, 2024

Conversation

gaetbout
Copy link
Contributor

@gaetbout gaetbout commented Jun 27, 2024

The remaining untested error messages are:
gift-fac/transfer-fee-failed, gift-fac/transfer-failed and escr-lib/transfer-failed

@sgc-code
Copy link
Contributor

@gaetbout should we close this now? or is it still useful?

@gaetbout
Copy link
Contributor Author

The merge went wrong...
But I found out a bunch of error message that aren't tested.
I'd like to add these missing tests

@gaetbout gaetbout changed the base branch from align-error-message to develop June 28, 2024 09:58
@gaetbout gaetbout changed the title Only used for comparison atm Adding more tests relatedd to untested error messages Jun 28, 2024
@gaetbout gaetbout marked this pull request as ready for review June 28, 2024 12:04
@gaetbout gaetbout requested a review from Leonard-Pat June 28, 2024 12:04
@gaetbout gaetbout changed the title Adding more tests relatedd to untested error messages Adding more tests related to untested error messages Jul 1, 2024
lib/signers/legacy.ts Outdated Show resolved Hide resolved
@gaetbout gaetbout requested a review from sgc-code July 1, 2024 09:04
@sgc-code sgc-code merged commit f4d21a8 into develop Jul 1, 2024
5 checks passed
@sgc-code sgc-code deleted the align-error-message-tests branch July 5, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants