Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to job rm #379

Merged
merged 8 commits into from
Nov 29, 2023
Merged

updates to job rm #379

merged 8 commits into from
Nov 29, 2023

Conversation

cms21
Copy link
Contributor

@cms21 cms21 commented Oct 30, 2023

These changes are in response to issue #374

@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (10f5d27) 60.69% compared to head (e6f2105) 60.52%.
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   60.69%   60.52%   -0.17%     
==========================================
  Files         157      157              
  Lines        9677     9687      +10     
  Branches     1271     1275       +4     
==========================================
- Hits         5873     5863      -10     
- Misses       3544     3564      +20     
  Partials      260      260              
Files Coverage Δ
balsam/__init__.py 100.00% <100.00%> (ø)
balsam/_api/models.py 94.57% <100.00%> (ø)
balsam/site/launcher/_mpi_mode.py 77.58% <ø> (-0.13%) ⬇️
balsam/_api/model.py 76.22% <0.00%> (-2.10%) ⬇️
balsam/config/config.py 81.44% <0.00%> (ø)
balsam/cmdline/job.py 29.41% <26.66%> (-0.13%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cms21 cms21 merged commit 40688ec into main Nov 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants